feat(lambda): container images #11809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original CFN patch updated `Runtime` and `Handler` fields (changed optionality). Because of how json-patch works and the fact that currently our lambda function hash calculation is order-sensitive, it caused invalidation of all lambda hashes. To avoid that, we use a marker value to signal that the value should be removed by an escape hatch. This should be reverted once the new CFN spec is published.
|
|
nija-at
force-pushed
the
nija-at/supernova
branch
from
1a108e8 to
e55f3cc
Compare
NetaNir
approved these changes
Dec 1, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This is amazing that y'all support this so quickly. Thank you! Excited to try this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for deploying ECR container images as Lambda function
handlers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license