Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ec2): multipart user data #11843
feat(ec2): multipart user data #11843
Changes from all commits
e8c7733
b84fa3a
a013138
f50d10b
5338f1d
2563648
bc6e06c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why get rid of the
addUserDataPart(userData, contentType)
here? I rather liked it as a convenience method.(Of course it's not strictly necessary, but it reads nicer than the current alternative)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsmogura @rix0rrr L513-L532 Are these deprecated now? If they are, can we use
@deprecated
docstrings?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think now I understand why
addCommand
was not doing anything :) https://cdk-dev.slack.com/archives/C018XT6REKT/p1615356365150500cc @fogfish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robertd - I think it's not deprecated. You still can use other script parts as the body of archive.
However with multiply you may try to use x-include-url Content Type
https://cloudinit.readthedocs.io/en/latest/topics/format.html#include-file
And I'm glad you did find an answer for your question.