Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): getting started instructions for csharp #1185

Merged
merged 2 commits into from
Nov 16, 2018

Conversation

costleya
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Even if the reference source directory exists, it takes a long time to copy the files. Deleting this directory is not preferable since the generation toime is also long. Therefore, setting the flag will now always skip reference file copying on the BUILD_DOCS_DEV variable being set.
@costleya costleya requested review from eladb and Doug-AWS November 15, 2018 20:28
@eladb
Copy link
Contributor

eladb commented Nov 15, 2018

@Doug-AWS please re-review and merge when ready.

Please make sure to modify the title of the commit to:

feat(docs): getting started instructions for csharp

@RomainMuller RomainMuller changed the title Add C# getting started feat(docs): getting started instructions for csharp Nov 16, 2018
@RomainMuller
Copy link
Contributor

I re-titled the PR so the merge web-flow should provide the correct commit title 😉

Copy link
Contributor

@Doug-AWS Doug-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Doug-AWS Doug-AWS merged commit 2915ac1 into aws:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants