feat(toolkit): improve diff user interface #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2018 23:10
`DifferenceCollection#applyFilter` can be used to delete any changes that do not pass the predicate from the collection. Changed `DifferenceCollection#count` to do a lazy calculation since now `changes` is mutable. The toolkit switch `cdk diff --strict` disables this behavior. Fixes #465
- When possible, display element's construct path alongside logical ID (fixes #1121) - Sort changes according to type: removed > added > updated > other - Add section headers: parameters, resources, output (fixes #1120) - Reduce clutter and emojis To display construct path we fuse metadata from the synthesized output (CDK metadata) and info from the the "aws:cdk:path" CloudFormation metadata (if exists).
|
If we resolve |
rix0rrr
approved these changes
Nov 16, 2018
RomainMuller
approved these changes
Nov 16, 2018
eladb
changed the base branch from
benisrae/hide-metadata-resource
to
master
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
logical ID (fixes cdk diff: show element path and not only logical id #1121)
output (fixes cdk diff: doesn't doesn't indicate "parameters" and "outputs" #1120)
To display construct path we fuse metadata from the synthesized output
(CDK metadata) and info from the the "aws:cdk:path" CloudFormation
metadata (if exists).
TODO:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.