-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecr): configure immutable tags for ecr repo #11954
feat(ecr): configure immutable tags for ecr repo #11954
Conversation
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
dc4a6a7
to
0567ff2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Broader question: should the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following files have unnecessary changes. Would appreciate if you could clean these up.
You can do yarn install --frozen-lockfile
to install without upgrading versions in yarn.lock.
.github/actions/prlinter/package.json
packages/cdk/package.json
packages/decdk/test/fixture/package.json
tools/yarn-cling/test/test-fixture/package1/package.json
tools/yarn-cling/test/test-fixture/package2/package.json
yarn.lock
/** | ||
* Enable image tag references to be mutable | ||
* | ||
* @default true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default for this is actually false
right? When you pass undefined
to the L1, then the default value is MUTABLE
as documented here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I believe that the name of this property should be imageTagMutability
to match the underlying L1 and the type should be an Enum. Even though there are only two options this feels like the best balance between safety and verbosity. The users of the L2 don't need to know to put 'MUTABLE' or 'IMMUTABLE' they just select an option on the Enum and this ensures that in the future if new options are added (idk what those would be but whatever) we can handle those.
this is duplicate of : https://github.com/aws/aws-cdk/pull/10557/files |
Closing this since #10557 got merged. |
When creating an ecr repo allow tags to be immutable by setting the ImageTagMutability field found here:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecr-repository.html#cfn-ecr-repository-imagetagmutability
Trying to get the minor version bump script to work at the moment.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license