Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cxapi): use enums in tests instead of strings to match type #11993

Merged
merged 2 commits into from
Dec 10, 2020
Merged

chore(cxapi): use enums in tests instead of strings to match type #11993

merged 2 commits into from
Dec 10, 2020

Conversation

shivlaks
Copy link
Contributor

These fail with the bump of @types/jest in #11948

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@shivlaks shivlaks added the @aws-cdk/cx-api Related to the Cloud Executable API label Dec 10, 2020
@shivlaks shivlaks requested a review from a team December 10, 2020 16:49
@shivlaks shivlaks self-assigned this Dec 10, 2020
@gitpod-io
Copy link

gitpod-io bot commented Dec 10, 2020 •
edited
Loading

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ea55f29
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ef14325 into master Dec 10, 2020
@mergify mergify bot deleted the shivlaks/cxapi-chore branch December 10, 2020 18:17
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@shivlaks @flochaz
chore(cxapi): use enums in tests instead of strings to match type (aw…
cb6069e 
…s#11993)

These fail with the bump of @types/jest in aws#11948


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@shivlaks shivlaks

Labels
@aws-cdk/cx-api Related to the Cloud Executable API contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shivlaks @aws-cdk-automation @nija-at