Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-autoscaling): Add hook ordering dependency #1218

Merged
merged 2 commits into from
Nov 21, 2018
Merged

fix(aws-autoscaling): Add hook ordering dependency #1218

merged 2 commits into from
Nov 21, 2018

Commits on Nov 20, 2018

  1. fix(aws-autoscaling): Add hook ordering dependency 

    Add an ordering dependency between the LifecycleHook and the role policy
that grants permissions to perform the action (publish to a topic or
queue).

Without this ordering dependency, the template might fail to deploy.

Fixes #1212.
    @rix0rrr
    rix0rrr committed Nov 20, 2018
    Configuration menu
    Copy the full SHA
    698e3a8 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Update test expectations, review comments

    @rix0rrr
    rix0rrr committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    0dfb943 View commit details
    Browse the repository at this point in the history