Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(init-templates/python): correct virtual environment typo #12230

Merged
merged 7 commits into from
Feb 25, 2021

Conversation

idanlupinsky
Copy link
Contributor


This is a suggested fix for #12229, a small typo in the init templates for Python.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 26, 2020

@mergify
Copy link
Contributor

mergify bot commented Dec 26, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@idanlupinsky idanlupinsky changed the title Correct virtual environment typo fix(docs): correct virtual environment typo Dec 26, 2020
@idanlupinsky idanlupinsky changed the title fix(docs): correct virtual environment typo fix(init-templates/python): correct virtual environment typo Dec 26, 2020
@idanlupinsky idanlupinsky changed the title fix(init-templates/python): correct virtual environment typo chore(init-templates/python): correct virtual environment typo Dec 27, 2020
@idanlupinsky idanlupinsky changed the title chore(init-templates/python): correct virtual environment typo init-templates/python: correct virtual environment typo Dec 27, 2020
@idanlupinsky idanlupinsky changed the title init-templates/python: correct virtual environment typo fix(init-templates/python): correct virtual environment typo Dec 27, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@NGL321 NGL321 added the package/tools Related to AWS CDK Tools or CLI label Jan 23, 2021
rix0rrr
rix0rrr previously requested changes Feb 9, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflict? Looks like this has been addressed already.

Otherwise, I think I'd rather have both .env and .venv in there.

@mergify mergify bot dismissed rix0rrr’s stale review February 9, 2021 16:07

Pull request has been modified.

@idanlupinsky idanlupinsky changed the title fix(init-templates/python): correct virtual environment typo chore(init-templates/python): correct virtual environment typo Feb 9, 2021
@idanlupinsky
Copy link
Contributor Author

Done @rix0rrr

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2d81e2a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 146a97f into aws:master Feb 25, 2021
@idanlupinsky idanlupinsky deleted the fix-python-template-gitignore branch February 27, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants