fix(aws-elasticloadbalancingv2): target group metrics #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TargetGroup metrics used to use ${TargetGroup.LoadBalancerArns} to find
the load balancer's full name, but that introduces a deployment-time
ordering dependency on the creation of the Listener object.
Instead, use the Listener ARN to get the load balancer name. We
now have an ordering requirement in the CDK code but that can be
detected early and solved by the user.
Fixes #1213.
RomainMuller
approved these changes
Nov 21, 2018
| @@ -365,3 +360,9 @@ export interface LoadBalancerTargetProps { | |||
| */ | |||
| targetJson?: any; | |||
| } | |||
|
|
|||
| export function loadBalancerNameFromListenerArn(listenerArn: string) { | |||
| // arn:aws:elasticloadbalancing:us-west-2:123456789012:listener/app/my-load-balancer/50dc6c495c0c9188/f2f7dc8efc522ab2 | |||
There was a problem hiding this comment.
Would prefer this to be part of the function JSDoc as an example, and I think it'd be nice to have the corresponding output, too (aka what part are we extracting in fact).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TargetGroup metrics used to use ${TargetGroup.LoadBalancerArns} to find
the load balancer's full name, but that introduces a deployment-time
ordering dependency on the creation of the Listener object.
Instead, use the Listener ARN to get the load balancer name. We
now have an ordering requirement in the CDK code but that can be
detected early and solved by the user.
Fixes #1213.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.