Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(appsync): improved example DynamoDB stack in AppSync README.md file #12320

Merged
merged 10 commits into from
Jan 13, 2021

Conversation

tlakomy
Copy link
Contributor

@tlakomy tlakomy commented Jan 3, 2021

MappingTemplate is not a global value and it has to either be explicitly imported:

import { MappingTemplate } from '@aws-cdk/aws-appsync';

or accessed via appsync field (since there is an import * as appsync from '@aws-cdk/aws-appsync'; on line 55).

It's a small thing but now the whole example code is more or less copy&paste-able 👍 (same goes for PrimaryKey and Values)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 3, 2021

@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Jan 3, 2021
MrArnoldPalmer
MrArnoldPalmer previously approved these changes Jan 13, 2021
@mergify mergify bot dismissed MrArnoldPalmer’s stale review January 13, 2021 01:08

Pull request has been modified.

MrArnoldPalmer
MrArnoldPalmer previously approved these changes Jan 13, 2021
@mergify mergify bot dismissed MrArnoldPalmer’s stale review January 13, 2021 04:50

Pull request has been modified.

@MrArnoldPalmer
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Command update: success

Branch has been successfully updated

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@MrArnoldPalmer
Copy link
Contributor

@tlakomy just FYI mergify should auto update from master if its able and wont dismiss reviews when it does. You may have just needed to manually merge for some reason or other though and may already know this.

Regardless, TY!

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 9d1fc41
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c14e641 into aws:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants