Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-nodejs): invalid sample in documentation #12404

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

mmuller88
Copy link
Contributor

Otherwise it is highly confusing or / and even wrong


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Otherwise it is highly confusing or / and even wrong
@gitpod-io
Copy link

gitpod-io bot commented Jan 7, 2021

@NGL321 NGL321 changed the title fix: aws-lambda-nodejs documentation fix(aws-lambda-nodejs): aws-lambda-nodejs documentation Jan 23, 2021
eladb
eladb previously approved these changes Jan 28, 2021
@mergify mergify bot dismissed eladb’s stale review January 28, 2021 08:05

Pull request has been modified.

@eladb eladb added the pr-linter/exempt-test The PR linter will not require test changes label Jan 28, 2021
@eladb eladb changed the title fix(aws-lambda-nodejs): aws-lambda-nodejs documentation fix(lambda-nodejs): sample in documentation Jan 28, 2021
@eladb eladb changed the title fix(lambda-nodejs): sample in documentation fix(lambda-nodejs): invalid sample in documentation Jan 28, 2021
@jogold
Copy link
Contributor

jogold commented Feb 23, 2021

@eladb this can be merged, no?

eladb
eladb previously approved these changes Feb 23, 2021
@mergify mergify bot dismissed eladb’s stale review February 23, 2021 07:56

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 99e11c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 520c263 into aws:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-nodejs pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants