Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-deployment): User metadata keys have redundant triple x-amz prefix #12414

Merged
merged 4 commits into from
Jan 21, 2021
Merged

fix(s3-deployment): User metadata keys have redundant triple x-amz prefix #12414

merged 4 commits into from
Jan 21, 2021

Commits on Jan 18, 2021

  1. fix(s3-deployment): Fix duplicate x-amz-meta- prefix for user metadata

    Without this fix, keys are prefixed with x-amzn-meta- by the TypeScript code,
    then the Python code runs and prefixes metadata keys again with x-amz-meta-.
    Then, the Python shells out to aws-cli which makes a request to the S3 service.
    There, the keys are prefixed *yet again* with x-amz-meta- _unconditionally_.
    
    Thus no matter what keys the user specified, the keys in S3 would be:
    x-amz-meta-x-amz-meta-x-amzn-meta-<user input>.
    
    This issue was originally reported as #8459.
    
    After this change, neither the TypeScript code nor the Python code will attempt
    to prepend to the metadata key. Instead we rely on the S3 service to do it.
    bmwalters committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    2d15c8d View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2021

  1. Configuration menu
    Copy the full SHA
    f0e1c66 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c76d74d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd16d8d View commit details
    Browse the repository at this point in the history