feat(glue): Connection construct #12444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
humanzz
changed the title
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
humanzz
changed the title
|
I will add integration tests as well so this is likely not final. |
humanzz
changed the title
This was referenced Jan 14, 2021
iliapolo
changed the title
iliapolo
reviewed
Feb 14, 2021
|
@iliapolo I think I might have wrongly rebased things which brought in unnecessary commits into this diff. Apologies for that |
follow the pattern in Lambda's Runtime to use a class with static members instead of enum
iliapolo
added
the
response-requested
- add addProperty escape hatch in Connection - Extract ConnectionOptopns out of ConnectionProps - implement MongoDBConnection as a subclass of Connection
iliapolo
reviewed
Feb 15, 2021
humanzz
changed the title
github-actions
bot
removed
the
response-requested
iliapolo
reviewed
Feb 16, 2021
iliapolo
reviewed
Feb 16, 2021
iliapolo
reviewed
Feb 16, 2021
iliapolo
reviewed
Feb 16, 2021
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
Co-authored-by: Eli Polonsky <Eli.polonsky@gmail.com>
iliapolo
reviewed
Feb 17, 2021
iliapolo
previously approved these changes
Feb 17, 2021
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
approved these changes
Feb 17, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
Closes aws#12442 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb
pushed a commit
that referenced
this pull request
Feb 22, 2021
Closes #12442 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12442
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license