Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ec2): MachineImage.genericLinux/Windows don't work in environment-agnostic stacks #12546

Merged
merged 6 commits into from
Feb 9, 2021
Merged

fix(ec2): MachineImage.genericLinux/Windows don't work in environment-agnostic stacks #12546

merged 6 commits into from
Feb 9, 2021

Conversation

wchaws
Copy link
Contributor

@wchaws wchaws commented Jan 16, 2021 •
edited
Loading

Close #8759

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 16, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jan 16, 2021
@wchaws wchaws force-pushed the master branch 2 times, most recently from fa753d1 to c322545 Compare January 17, 2021 05:05
rix0rrr
rix0rrr previously requested changes Jan 18, 2021
View reviewed changes
packages/@aws-cdk/aws-ec2/lib/machine-image.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed rix0rrr’s stale review January 19, 2021 03:45

Pull request has been modified.

@wchaws
Copy link
Contributor Author

wchaws commented Feb 5, 2021

@rix0rrr updated!!

@wchaws wchaws requested a review from rix0rrr February 5, 2021 14:29
@rix0rrr rix0rrr changed the title feat(@aws-cdk/aws-ec2): make GenericMachineImage use CfnMapping in an agnostic stack (#8759) fix(ec2): MachineImage.genericLinux/Windows don't work in environment-agnostic stacks Feb 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ad06392
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fbe7e89 into aws:master Feb 9, 2021
TLadd pushed a commit to TLadd/aws-cdk that referenced this pull request Feb 9, 2021
@wchaws @TLadd
fix(ec2): MachineImage.genericLinux/Windows don't work in environment…
8cc931e 
…-agnostic stacks (aws#12546)

Close aws#8759


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
@wchaws @NovakGu
fix(ec2): MachineImage.genericLinux/Windows don't work in environment…
7382d08 
…-agnostic stacks (aws#12546)

Close aws#8759


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EC2] make GenericMachineImage use CfnMapping in an agnostic stack
3 participants
@wchaws @aws-cdk-automation @rix0rrr