feat(ecs-patterns): Add PlatformVersion option to ScheduledFargateTask props #12676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #12623 - Add extra parameter to the ScheduledFargateTaskProps to allow PlatformVersion to be passed. Rearranged code to handle EC2 & Fargate lanuch types correctly
Add a new test to cover the changes in the previous commit. Tests whether the Rule Target has a defined platform version (1.4.0) rather than the default LATEST
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
Rearrange the imports into the correct order
richardhughes
changed the title
Add a new section to the readme to explain the platform version option
Change double quotes to single quotes
NGL321
changed the title
piradeepk
reviewed
Jan 29, 2021
packages/@aws-cdk/aws-ecs-patterns/lib/base/scheduled-task-base.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/ecs/scheduled-ecs-task.ts
Outdated
Show resolved
Hide resolved
piradeepk
added
@aws-cdk/aws-ecs-patterns
piradeepk
changed the title
Revert the code to remove the function breaking change. EC2 Task uses old functions and the Fargate Task builds the ECS Task and then adds it to the target separately
piradeepk
reviewed
Jan 29, 2021
packages/@aws-cdk/aws-ecs-patterns/lib/base/scheduled-task-base.ts
Outdated
Show resolved
Hide resolved
piradeepk
reviewed
Jan 29, 2021
packages/@aws-cdk/aws-ecs-patterns/lib/ecs/scheduled-ecs-task.ts
Outdated
Show resolved
Hide resolved
piradeepk
reviewed
Jan 29, 2021
fix some PR issues and add a comment and remove the ecstask import
|
All fixed, Thanks @piradeepk :) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
piradeepk
approved these changes
Jan 30, 2021
There was a problem hiding this comment.
Ship it! 💯 Thanks for adding this feature @richardhughes! This is awesome!
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the platformversion as an extra option to the Fargate Scheduled Task
closes #12623
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license