Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-cloudtrail): correct S3 bucket policy and dependency chain #1268

Merged
merged 2 commits into from
Dec 3, 2018
Merged

fix(aws-cloudtrail): correct S3 bucket policy and dependency chain #1268

merged 2 commits into from
Dec 3, 2018

Conversation

randomvariable
Copy link
Contributor

@randomvariable randomvariable commented Dec 1, 2018


Fixes #1172

Pull Request Checklist

Please check all boxes (including N/A items)

Testing

  • [c] Unit test and/or integration test added
  • Toolkit change?: integration
    tests

    manually executed (paste output to the PR description)
  • Init template change?: coordinated update of integration tests
    (currently maintained in a private repo).

Documentation

  • README: README and/or documentation topic updated
  • jsdocs: All public APIs documented

Title and description

  • Change type: Title is prefixed with change type:
    • fix(module): <title> bug fix (patch)
    • feat(module): <title> feature/capability (minor)
    • chore(module): <title> won't appear in changelog
    • build(module): <title> won't appear in changelog
  • Title format: Title uses lower case and doesn't end with a period
  • Breaking change?: Last paragraph of description is: BREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>
  • References: Indicate issues fixed via: Fixes #xxx or Closes #xxx

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@randomvariable randomvariable changed the title [WIP] Cloudtrail fixup Cloudtrail fixup Dec 3, 2018
@randomvariable randomvariable changed the title Cloudtrail fixup fix(aws-cloudtrail): correct S3 bucket policy and dependency chain Dec 3, 2018
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rix0rrr rix0rrr merged commit 0de2da8 into aws:master Dec 3, 2018
@randomvariable randomvariable deleted the cloudtrail-fixup branch December 3, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudTrail missing DependsOn and /* , cdk deploy fails Incorrect S3 bucket policy is detected for bucket
2 participants