Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): cannot use the same Role for multiple Config Rules #12724

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 27, 2021

This, or any other construct that adds Managed Policies to a Role
by default; Managed Policy ARNs need to be deduplicated, otherwise
CloudFormation will throw an error upon creation.

Slightly more complicated than you'd expect in order to deal with
Tokens.

Fixes #12714.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This, or any other construct that adds Managed Policies to a Role
by default; Managed Policy ARNs need to be deduplicated, otherwise
CloudFormation will throw an error upon creation.

Slightly more complicated than you'd expect in order to deal with
Tokens.

Fixes #12714.
@rix0rrr rix0rrr requested a review from a team January 27, 2021 09:53
@rix0rrr rix0rrr self-assigned this Jan 27, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jan 27, 2021

@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Jan 27, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2f6521a into master Jan 27, 2021
@mergify mergify bot deleted the huijbers/dupe-roles branch January 27, 2021 18:34
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2d0f1dd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws_iam): service roles are doubled, causing a fatal error, when using the same role for 2 resources
3 participants