fix(core): append file extension to s3 asset key in new style synthesizer #12765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer - This change fixes the issue with new style synthesizer, when s3 files assets are uploaded without file extension. This was breaking integration with some services, in particular Glue, which requires jar files to have "jar" extension in order to compile. - Legacy synthesizer was uploading files with extensions, so this changes effectively aligns old and new synthesizers. fixes aws#12740
|
|
rix0rrr
previously approved these changes
Feb 4, 2021
rix0rrr
approved these changes
Feb 4, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Feb 5, 2021
In #12765, a bug was introduced where there was a mismatch between the file entry written to the asset manifest for the stack template, and the template location written to the cloud assembly, thereby causing all deployments to fail. The error was "Access Denied" (because that's what S3 says when it doesn't want to tell you "File not found"). Fix the inconsistency.
mergify bot
pushed a commit
that referenced
this pull request
Feb 5, 2021
In #12765, a bug was introduced where there was a mismatch between the file entry written to the asset manifest for the stack template, and the template location written to the cloud assembly, thereby causing all deployments to fail. The error was "Access Denied" (because that's what S3 says when it doesn't want to tell you "File not found"). Fix the inconsistency. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
…izer (aws#12765) - This change fixes the issue with new style synthesizer, when s3 files assets are uploaded without file extension. This was breaking integration with some services, in particular Glue, which requires jar files to have "jar" extension in order to compile. - Legacy synthesizer was creating s3 key with extension, so this change effectively aligns old and new synthesizers. fixes aws#12740 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
In aws#12765, a bug was introduced where there was a mismatch between the file entry written to the asset manifest for the stack template, and the template location written to the cloud assembly, thereby causing all deployments to fail. The error was "Access Denied" (because that's what S3 says when it doesn't want to tell you "File not found"). Fix the inconsistency. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12740
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license