feat(ecs): allow selection of container and port for SRV service discovery records #12798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
misterjoshua
changed the title
|
It looks like the build is failing because of something to do with poetry in |
|
@SoManyHs I've resolved the merge conflict. This PR is back to being ready for review. Let me know what you'll need me to change. Thanks. |
This was referenced Mar 8, 2021
Merged
Closed
Closed
cornerwings
pushed a commit
to cornerwings/aws-cdk
that referenced
this pull request
Mar 8, 2021
…overy records (aws#12798) Adds `container` and `containerPort` as optional properties of `CloudMapOptions`. This change allows the user to select which container and container port the `SRV` record points to. Closes aws#12796 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
containerandcontainerPortas optional properties ofCloudMapOptions. This change allows the user to select which container and container port theSRVrecord points to.Closes #12796
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license