-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): support Fargate and Fargate spot capacity providers #12893
Merged
+918
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoManyHs
force-pushed
the
fargate-capacity-providers
branch
13 times, most recently
from
February 8, 2021 19:58
9ddb0f8
to
45c5693
Compare
SoManyHs
force-pushed
the
fargate-capacity-providers
branch
from
February 9, 2021 18:21
45c5693
to
1abf093
Compare
piradeepk
reviewed
Feb 9, 2021
SoManyHs
force-pushed
the
fargate-capacity-providers
branch
3 times, most recently
from
February 15, 2021 18:42
30eac70
to
3e5fd57
Compare
SoManyHs
commented
Feb 15, 2021
MrArnoldPalmer
requested changes
Feb 16, 2021
SoManyHs
force-pushed
the
fargate-capacity-providers
branch
from
February 16, 2021 18:53
2c8a41f
to
230b54c
Compare
SoManyHs
force-pushed
the
fargate-capacity-providers
branch
from
February 16, 2021 18:55
230b54c
to
55f7f36
Compare
MrArnoldPalmer
approved these changes
Feb 16, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@SoManyHs Thank you for adding this option. Is it going to be available in ecs-patterns as well? |
eladb
pushed a commit
that referenced
this pull request
Feb 22, 2021
Fixes #5850 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ecs
Related to Amazon Elastic Container
contribution/core
This is a PR that came from AWS.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5850
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license