fix(appsync): revert to allow resolver creation from data source #12973
Conversation
|
|
|
@p0wl @asnaseer-resilient I thinks it is best to keep both functionality as PIPELINE resolvers should be tied to a GraphqlApi as well |
|
Nice! Thanks!! |
BryanPan342
changed the title
|
Anything that I/we can do to get this merged? This is blocking us quite a bit. |
I think we are just waiting on a maintainer to accept these changes. @MrArnoldPalmer this seems like a |
|
Hey @BryanPan342, added a question to the original issue #12635 (comment). Respond here or there, either way. |
MrArnoldPalmer
added
the
response-requested
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
) * Revert to old behavior of allowing a data source to create a resolver as UNIT resolvers stem from data sources. * Maintaining new behavior of having `GraphqlApi` create resolvers as PIPELINE resolvers stem from the `GraphqlApi` itself Fixes #12635 Fixes #11522 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This is a breaking change. Broke all my revolvers. How do we work around this? Feeling a little disappointed that:
|
GraphqlApicreate resolvers as PIPELINE resolvers stem from theGraphqlApiitselfFixes #12635
Fixes #11522
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license