Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rds): use nodeunit-shim #13077

Merged
merged 1 commit into from
Feb 16, 2021
Merged

chore(rds): use nodeunit-shim #13077

merged 1 commit into from
Feb 16, 2021

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 16, 2021

Use jest for RDS tests, as I plan to add data-driven tests.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Use `jest` for RDS tests, as I plan to add data-driven tests.
@rix0rrr rix0rrr requested a review from a team February 16, 2021 10:24
@rix0rrr rix0rrr self-assigned this Feb 16, 2021
@gitpod-io
Copy link

gitpod-io bot commented Feb 16, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 16, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Feb 16, 2021
@nija-at nija-at changed the title chore(rds): use nodeunit-shim chore(rds): use nodeunit-shim Feb 16, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 468b8cd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 355fed8 into master Feb 16, 2021
@mergify mergify bot deleted the huijbers/rds-jest branch February 16, 2021 10:58
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
Use `jest` for RDS tests, as I plan to add data-driven tests.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
Use `jest` for RDS tests, as I plan to add data-driven tests.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants