chore: enable feature flags on all integ tests #13110
Conversation
|
|
nija-at
force-pushed
the
nija-at/featureflags-integtests
branch
from
4db52ec
to
d2d8803
Compare
| @@ -337,7 +337,11 @@ export const DEFAULT_SYNTH_OPTIONS = { | |||
| }, | |||
| ], | |||
| }, | |||
| // Enable feature flags for all integ tests | |||
There was a problem hiding this comment.
Don't we want to simply enable all feature flags? (i.e. iterate over the keys and add them all, same as we do in the CLI when a new project is created).
There was a problem hiding this comment.
Eventually yes. See PR description.
There was a problem hiding this comment.
Also, this is in cdk-integ-tools and the list of feature flags is in cx-api. It would not be possible to obtain the list here.
There was a problem hiding this comment.
Actually, I see that cdk-integ-tools already depends on cx-api. I'll update this accordingly in a subsequent PR.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Most feature flags will be expired in CDKv2 and their 'enabled' behaviour made the default. To keep the divergence between the two branches (`master` and `v2-main`) to a minimum, update all integration tests to have the flags enabled. If the flag needs to be different for any specific test, it can be overridden when constructing the `App` object. To keep the set of changes small, only the following flags have been added. The rest will be added in a subsequent change. - @aws-cdk/aws-kms:defaultKeyPolicies - @aws-cdk/core:enableStackNameDuplicates - @aws-cdk/aws-secretsmanager:parseOwnedSecretName Currently, only these three feature flags are expired in CDKv2. Fixing them first will make the branch divergence smaller and reduce already occuring [merge conflicts]. [merge conflicts]: aws#13099 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Most feature flags will be expired in CDKv2 and their 'enabled' behaviour made the default. To keep the divergence between the two branches (`master` and `v2-main`) to a minimum, update all integration tests to have the flags enabled. If the flag needs to be different for any specific test, it can be overridden when constructing the `App` object. To keep the set of changes small, only the following flags have been added. The rest will be added in a subsequent change. - @aws-cdk/aws-kms:defaultKeyPolicies - @aws-cdk/core:enableStackNameDuplicates - @aws-cdk/aws-secretsmanager:parseOwnedSecretName Currently, only these three feature flags are expired in CDKv2. Fixing them first will make the branch divergence smaller and reduce already occuring [merge conflicts]. [merge conflicts]: #13099 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Most feature flags will be expired in CDKv2 and their 'enabled'
behaviour made the default.
To keep the divergence between the two branches (
masterandv2-main) to a minimum, update all integration tests to have theflags enabled.
If the flag needs to be different for any specific test, it can be
overridden when constructing the
Appobject.To keep the set of changes small, only the following flags have
been added. The rest will be added in a subsequent change.
Currently, only these three feature flags are expired in CDKv2.
Fixing them first will make the branch divergence smaller and
reduce already occuring merge conflicts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license