Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): ENOTDIR invalid cwd on "cdk deploy" #13145

Merged
merged 2 commits into from
Feb 19, 2021
Merged

fix(core): ENOTDIR invalid cwd on "cdk deploy" #13145

merged 2 commits into from
Feb 19, 2021

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Feb 19, 2021

This commit reverts two recent changes to the asset system (#12258 and ##13076) which introduced a regression in 1.90.0.

Fixes #13131

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fix: ENOTDIR invalid cwd on "cdk deploy"
40b7932 
This commit reverts two recent changes to the asset system  (#12258 and ##13076) which introduced a regression in 1.90.0.

Fixes #13131
@gitpod-io
Copy link

gitpod-io bot commented Feb 19, 2021 •
edited
Loading

@eladb eladb requested a review from NetaNir February 19, 2021 07:11
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Feb 19, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 19, 2021
@eladb eladb mentioned this pull request Feb 19, 2021
Closed
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 36df906
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cd7a3ed into master Feb 19, 2021
@mergify mergify bot deleted the benisrae/fix-1-90 branch February 19, 2021 08:17
NetaNir pushed a commit that referenced this pull request Feb 19, 2021
@NetaNir
fix(core): ENOTDIR invalid cwd on "cdk deploy" (#13145)
a735b52 
This commit reverts two recent changes to the asset system  (#12258 and ##13076) which introduced a regression in 1.90.0.

Fixes #13131

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
fix(core): ENOTDIR invalid cwd on "cdk deploy" (#13145)
75a5966 
This commit reverts two recent changes to the asset system  (#12258 and ##13076) which introduced a regression in 1.90.0.

Fixes #13131

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
fix(core): ENOTDIR invalid cwd on "cdk deploy" (#13145)
909563f 
This commit reverts two recent changes to the asset system  (#12258 and ##13076) which introduced a regression in 1.90.0.

Fixes #13131


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetaNir NetaNir NetaNir approved these changes

Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/core Related to core CDK functionality contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

‼️ NOTICE: 'Error: ENOTDIR invalid cwd' on cdk deploy in 1.90.0
4 participants
@eladb @aws-cdk-automation @NetaNir @rix0rrr