Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stepfunctions): SageMakeUpdateEndpoint adds insufficient permissions #13170

Merged
merged 3 commits into from
Mar 3, 2021
Merged

fix(stepfunctions): SageMakeUpdateEndpoint adds insufficient permissions #13170

merged 3 commits into from
Mar 3, 2021

Conversation

zxkane
Copy link
Contributor

@zxkane zxkane commented Feb 20, 2021 •
edited by shivlaks
Loading

closes #11594

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 20, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-config Related to AWS Config label Feb 20, 2021
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Feb 20, 2021
@zxkane
Copy link
Contributor Author

zxkane commented Feb 23, 2021

@shivlaks could you review this one? Not sure why it’s not auto-tag with stepfunctions-tasks. Checking the paths of changed files is more stable way.

@zxkane zxkane changed the title fix(stepfunctions-task): add resource endpoint-config of IAM policy f… fix(stepfunctions-tasks): add resource endpoint-config of IAM policy f… Mar 3, 2021
@rix0rrr rix0rrr changed the title fix(stepfunctions-tasks): add resource endpoint-config of IAM policy f… fix(stepfunctions): SageMakeUpdateEndpoint adds insufficient permissions Mar 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Mar 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@shivlaks
Copy link
Contributor

shivlaks commented Mar 3, 2021

@zxkane LGTM

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: fa13362
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6126e49 into aws:master Mar 3, 2021
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
@zxkane @cornerwings
fix(stepfunctions): SageMakeUpdateEndpoint adds insufficient permis…
03b8cce 
…sions (aws#13170)

closes aws#11594

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

@MrArnoldPalmer MrArnoldPalmer

@shivlaks shivlaks

Labels
@aws-cdk/aws-config Related to AWS Config @aws-cdk/aws-iam Related to AWS Identity and Access Management @aws-cdk/aws-stepfunctions Related to AWS StepFunctions @aws-cdk/aws-stepfunctions-tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stepfunctions-tasks] SageMakerUpdateEndpoint creates wrong permissions
5 participants
@zxkane @shivlaks @aws-cdk-automation @rix0rrr @MrArnoldPalmer