Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(guidelines): guidance on which constructs are included in the CDK #13218

Merged
merged 10 commits into from
Mar 2, 2021
Merged

chore(guidelines): guidance on which constructs are included in the CDK #13218

merged 10 commits into from
Mar 2, 2021

Commits on Feb 23, 2021

  1. chore: design guidance on construct abstraction and inclusion in the CDK 

    Adding a section of general guidance in the DESIGN_GUIDELINES to explain the L1,
L2, and beyond constructs, and what types of behaviors L2s should include versus
what types likely belong in separate repositories.

This guidance is by no means complete or without controversy. I expect pushback
and hope for both more supporting examples as well as counter examples.
    @njlynch
    njlynch committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    09be729 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. dramatically simplify criteria

    @njlynch
    njlynch committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e9ea0ac View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. Merge remote-tracking branch 'origin/master' into njlynch/l2-criteria

    @njlynch
    njlynch committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    f5bce0f View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. Merge remote-tracking branch 'origin/master' into njlynch/l2-criteria

    @njlynch
    njlynch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    853fda4 View commit details
    Browse the repository at this point in the history

  2. Moved section, changed title, added deprecation note for L3s

    @njlynch
    njlynch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    1b9344d View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Elad's suggested changes.

Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
    @njlynch
    njlynch and Elad Ben-Israel authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    1f41c21 View commit details
    Browse the repository at this point in the history

  4. Fixed TOC. Examples of L2.5s and L3

    @njlynch
    njlynch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    4e1c53c View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into njlynch/l2-criteria

    @njlynch
    njlynch committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    622994e View commit details
    Browse the repository at this point in the history

  6. Update DESIGN_GUIDELINES.md

    Elad Ben-Israel authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    e308778 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into njlynch/l2-criteria

    @mergify
    mergify[bot] authored Mar 2, 2021
    Configuration menu
    Copy the full SHA
    d092144 View commit details
    Browse the repository at this point in the history