fix(apigatewayv2): error while configuring ANY as an allowed method in CORS

[robertd]

API gateway expects * to represent ANY HTTP method. HttpMethod enum doesn't
have a value for that, thus causing errors when passing HttpMethod 's ANY option.

This commit introduces CorsHttpMethod enum which has a proper ANY mapping to *.

Closes #13280.
Closes #13643.

BREAKING CHANGE: The type of allowMethods property under corsPreflight
section is changed from HttpMethod to CorsHttpMethod.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[robertd]

@nija-at Please review when you get a moment. Thanks!

Edit: From OP

I would suggest to either create a separate enum for HTTP methods that aligns with what API gateway expects, or to internally map "ANY" to "*" during synthesis. It's wrong to claim that allowMethods accepts an array of HttpMethod when in fact not all possible values would be correct.

@nija-at I've decided to go with separate enum option because implementation looks much cleaner/clearer than monkey-patching it on the fly. Although, I do wish there was a proper enum extending feature in TypeScript. This solution would look even more elegant 😄.

Let me know what you think.

[nija-at]

Hello -

Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention.
We will get to your PR as soon as we are able to. Apologies for the delay.

[robertd]

Hello -

Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention.
We will get to your PR as soon as we are able to. Apologies for the delay.

No worries. Thanks for letting me know.

[nija-at]

Code changes look good to me.

I've fixed up the title and the 'BREAKING CHANGE' clause to more closely align with how we usually announce it.

Can you update the commit description (above the breaking changes clause and 'closes' statements)? This will go into the description of the 'git commit', so use the appropriate language.

Usually, the description should answer the two questions - 'Why is this change necessary?', 'How does this commit address the issue?'

Pull request has been modified.

[robertd]

@nija-at Done. Let me know if there is anything else I need to do. Thanks!

[robertd]

I've updated and force-pushed git commit title too.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 4404171
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).