Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoscaling): Add evaluationPeriods parameter for StepScalingPolicy #13315

Closed

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Feb 28, 2021

This PR adds evaluationPeriods used to override default value when creating StepScalingPolicy.
Do we need to differentiate between lower and upper alarms or they can share the same evaluationPeriods value?

Closes #13252.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2021

@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Feb 28, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f792432
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@robertd
Copy link
Contributor Author

robertd commented Mar 12, 2021

@rix0rrr Since you've shipped #13366 (which is a superset of this PR) you can also close #13252 issue that my PR was trying to address. Thanks!

@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 12, 2021

Superseded by #13366

@rix0rrr rix0rrr closed this Mar 12, 2021
@robertd robertd deleted the robertd/autoscaling-step-scaling-policy branch March 12, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(autoscaling): StepScalingPolicy add evaluationPeriods parameter
4 participants