-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amplify-domain): Added config for auto subdomain creation #13342
Merged
mergify
merged 10 commits into
aws:master
from
janario:feature/enable-auto-subdomain-config
Mar 11, 2021
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c6407b5
feat(amplify-domain): Added config for auto subdomain creation
janario 19ac74d
feat(amplify-domain): Rename properties and adjusted optional. Code r…
janario fa4e936
Added doc with `AutoSubdomain` feature
janario 1d60deb
Added test case
janario d3a4d80
Merge branch 'master' into feature/enable-auto-subdomain-config
janario 9ddeb48
Fix lint
janario 3b6c1ef
Fix test
janario 3920c7b
Propagated autoSubDomainIamRole from App
janario d9a9540
Added default AutoSubDomainCreationPatterns
janario 13b9884
Merge branch 'master' into feature/enable-auto-subdomain-config
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it so that only when a user passes
enableAutoSubdomain: true
all branches will automatically get their own subdomains deployed right? ifenableAutoSubDomain: false
this default doesn't really matter right?This is fine with me I'm just making sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the web interface that's the behavior, by enabling
enableAutoSubDomain=true
all branches listen. But when I tried from the CloudFormation without providingautoSubdomainCreationPatterns
it didn't seem to get a default so I tried to keep a similar behaviourand yes, when
enableAutoSubDomain=false
theautoSubdomainCreationPatterns
is filled but ignored