Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: linter action should run on edits and label adjusts #13398

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Mar 4, 2021

Currently, PR linter only runs when the PR is opened. This naturally
means that when the title, description or labels (that it complains
about) is fixed, it does not re-run and confirm that it passes.

Adjust the action so it also runs when the PR labels, title or
descriptions are modified.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Currently, PR linter only runs when the PR is opened. This naturally
means that when the title, description or labels (that it complains
about) is fixed, it does not re-run and confirm that it passes.

Adjust the action so it also runs when the PR labels, title or
descriptions are modified.
@nija-at nija-at requested a review from a team March 4, 2021 16:08
@nija-at nija-at self-assigned this Mar 4, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@nija-at nija-at changed the title chore: PR linter GH action should run on edits and label adjusts chore: linter action should run on edits and label adjusts Mar 5, 2021
@nija-at nija-at merged commit 8e612ca into master Mar 5, 2021
@nija-at nija-at deleted the nija-at/prlinter-rerun branch March 5, 2021 15:00
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c511fdf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
Currently, the linter only runs when the PR is opened. This naturally
means that when the title, description or labels (that it complains
about) is fixed, it does not re-run and confirm that it passes.

Adjust the action so it also runs when the PR labels, title or
descriptions are modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants