Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): dead-letter queue support for CodeBuild #13448

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

DaWyz
Copy link
Contributor

@DaWyz DaWyz commented Mar 6, 2021

Resolves #13447


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 6, 2021

@github-actions github-actions bot added @aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-events Related to CloudWatch Events labels Mar 6, 2021
@rix0rrr rix0rrr changed the title feat(events): add dlq support for CodeBuild event target feat(events): dead-letter queue support for CodeBuild Mar 8, 2021
rix0rrr
rix0rrr previously approved these changes Mar 8, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thanks!

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review March 9, 2021 01:06

Pull request has been modified.

@DaWyz DaWyz requested a review from rix0rrr March 9, 2021 01:45
@DaWyz
Copy link
Contributor Author

DaWyz commented Mar 9, 2021

Need another approval here. There was a merge conflict in the readme.

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 43cea79
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild @aws-cdk/aws-events Related to CloudWatch Events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-events] Add DLQ Support for CodeBuildProject targets
4 participants