Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): imported EventBus does not correctly register source account #13481

Merged

Conversation

thantos
Copy link
Contributor

@thantos thantos commented Mar 9, 2021

Parses the event bus arn to give the account and region to the underlying Resource.

fixes #13469


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2021

@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Mar 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@thantos thantos changed the title fix(aws-events) account aware event bus import fix(aws-events): account aware event bus import Mar 9, 2021
Parses the event bus arn to give the account and region to the underlying Resource.

fixes aws#13469
@thantos thantos force-pushed the thantos/aws-events-imported-event-13469 branch from 15b86e2 to a2c60f1 Compare March 9, 2021 04:42
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a2c60f1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr changed the title fix(aws-events): account aware event bus import fix(events): imported EventBus does not correctly register source account Mar 9, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 9, 2021

Thanks for the fix!

@mergify
Copy link
Contributor

mergify bot commented Mar 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 57e5404 into aws:master Mar 9, 2021
This was referenced Mar 12, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-events): Imported Event Bus is not account aware.
3 participants