Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticloadbalancingv2): upgrade to v1.92.0 drops certificates on ALB if more than 2 certificates exist #13490

Merged
merged 2 commits into from
Mar 9, 2021

Commits on Mar 9, 2021

  1. fix(elasticloadbalancingv2): upgrade to v1.92.0 drops certificates on…

    … ALB if more than 2 certificates exist
    
    Support for multiple certificates attached to a single ALB listener was
    originally implemented by putting all certificates in an array on a single
    `ListenerCertificate` resource. The docs state that only one certificate may be
    specified, although multiple certificates do appear to work initially.  Initial
    resource creation of a `ListenerCertificate` with multiple certificates appears
    to succeed, but subsequent updates to this resource (to either add or remove
    certificates) yields undefined and undesireable behavior.
    
    The fix in #13332 attempted to fix this by creating a new `ListenerCertificate`
    per certificate, and -- at my direction -- maintained partial backwards
    compatibility by keeping the original ID for the first `ListenerCertificate`
    resource. However, this has the effect of triggering an update to the existing
    resource, which does not appear to work correctly.
    
    By forcing a logical ID change for all `ListenerCertificate` resources, we can
    force all existing resources to be deleted, and new resources created. This
    avoids doing any updates on any `ListenerCertificate` resources with an array
    of certificates, which appears to side-step the undefined behavior.
    
    fixes #13437
    njlynch committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    934e7e0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f8cfd3 View commit details
    Browse the repository at this point in the history