fix(codebuild): Rename includeBuildID property of S3BucketBuildArtifacts #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property name ending with `ID` caused a mismatch of names to appear in non-TypeScript languages, as the name translation rules would convert back to `Id`. BREAKING CHANGE: the `includeBuildID` property of `S3BucketBuildArtifacts` was renamed to `includeBuildId` (note the lower-case trailing `d`). Fixes #1347
eladb
reviewed
Dec 13, 2018
eladb
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property name ending with
IDcaused a mismatch of names to appearin non-TypeScript languages, as the name translation rules would convert
back to
Id.BREAKING CHANGE: the
includeBuildIDproperty ofS3BucketBuildArtifactswas renamed toincludeBuildId(note thelower-case trailing
d).Fixes #1347
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.