-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudwatch): period in GraphWidget #13555
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
I think doing this will break how metrics are rendered. Right now, when metrics render themselves they will render their own With this change, if you set the graph period to Can you describe the problem you are solving? We may need to do something else/more other than just forward a property to the user. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see Rico's comment
My primary use case was creating a I am not sure if there is an other use case where the |
This PR adds support for the period property in CloudWatch GraphWidgets.
The property in question can be seen here, under "period": https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Metric-Widget-Object
This fixes #6367
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license