feat(aws-ecs): Added dockerVolumeConfiguration to Volume #1357
+87
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cohalz
changed the title
eladb
reviewed
Dec 13, 2018
|
cc @SoManyHs |
|
fixed the pointed out part |
rix0rrr
reviewed
Dec 14, 2018
| /** | ||
| * Specifies this configuration when using Docker volumes | ||
| */ | ||
| dockerVolumeConfiguration?: DockerVolumeConfiguration; |
There was a problem hiding this comment.
I wonder if it makes sense to have these inline in the Volume struct.
As well as, why are the name and the configuration optional? Does it make sense to leave them optional?
I know @SoManyHs was working on a higher-level abstraction over volumes, so I'd like her to weigh in as well.
There was a problem hiding this comment.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-volumes.html
Thanks, I changed name to required.
There was a problem hiding this comment.
I will out of the office until the new year, but will try to take a look as soon as I can.
rix0rrr
approved these changes
Jan 15, 2019
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1356
Pull Request Checklist
Please check all boxes, including N/A items:
Testing
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.