Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline-actions): BitBucketAction fails with S3 "Access denied" error #13637

Merged
merged 4 commits into from
Mar 22, 2021

Conversation

BLasan
Copy link
Contributor

@BLasan BLasan commented Mar 17, 2021

Previously access control lists for putObject was not called.
This had led in getting access denied issue when trying to upload
objects into the s3 bucket

fixes #13557


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 17, 2021

@BLasan
Copy link
Contributor Author

BLasan commented Mar 17, 2021

@rix0rrr @skinny85 Please take a look

@skinny85 skinny85 self-assigned this Mar 17, 2021
@BLasan
Copy link
Contributor Author

BLasan commented Mar 17, 2021

@skinny85 Please review

@skinny85 skinny85 changed the title chore(aws-codepipeline-actions-bitbucket): add grantPutAcl to resolve the "Access denied" issue fix(codepipeline-actions): BitBucketAction fails with S3 "Access denied" error Mar 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Mar 17, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good @BLasan , thanks for the contribution!

It's missing a unit test though. Should be added to this file. The test itself should assert the Role gets the s3:PutObjectAcl permissions.

Thanks,
Adam

@skinny85 skinny85 removed the @aws-cdk/aws-s3 Related to Amazon S3 label Mar 17, 2021
@BLasan
Copy link
Contributor Author

BLasan commented Mar 18, 2021

Change looks good @BLasan , thanks for the contribution!

It's missing a unit test though. Should be added to this file. The test itself should assert the Role gets the s3:PutObjectAcl permissions.

Thanks,
Adam

Will make the changes :)

@mergify mergify bot dismissed skinny85’s stale review March 22, 2021 17:14

Pull request has been modified.

@BLasan BLasan force-pushed the issue-13557 branch 3 times, most recently from ee03fbf to 3d1c4b4 Compare March 22, 2021 18:18
BLasan added 3 commits March 22, 2021 23:48
… the access denied issue

Previously access control lists for putObject was not called.
This had led in getting access denied issue when trying to upload
objects into the s3 bucket
…ting s3:putObjectAcl to the codebuild-pipeline with bitbucket
@BLasan
Copy link
Contributor Author

BLasan commented Mar 22, 2021

@skinny85 Please take a look :)

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @BLasan!

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cdb5488
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 77ce45d into aws:master Mar 22, 2021
nija-at pushed a commit that referenced this pull request Mar 23, 2021
…ed" error (#13637)

Previously access control lists for putObject was not called.
This had led in getting access denied issue when trying to upload
objects into the s3 bucket

fixes #13557 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Mar 24, 2021
…ed" error (#13637)

Previously access control lists for putObject was not called.
This had led in getting access denied issue when trying to upload
objects into the s3 bucket

fixes #13557 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 24, 2021
…ed" error (aws#13637)

Previously access control lists for putObject was not called.
This had led in getting access denied issue when trying to upload
objects into the s3 bucket

fixes aws#13557 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ed" error (aws#13637)

Previously access control lists for putObject was not called.
This had led in getting access denied issue when trying to upload
objects into the s3 bucket

fixes aws#13557 


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(codepipeline-actions): BitBucketSourceAction requires s3:PutObjectAcl permissions
4 participants