chore(core): backport runtime-info test simplification from v2 branch #13665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes (plus import changes) were necessary to make these tests pass on the `v2-main` branch. Back-porting to `master` to (hopefully) reduce future forward-merge pain. The 'returns base construct info if no more specific info is present' test was removed as is wasn't truly necessary, and does not work with V2, where Construct comes from the `constructs` library instead of `core.Construct`.
|
|
github-actions
bot
added
@aws-cdk/core
nija-at
approved these changes
Mar 18, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
pushed a commit
that referenced
this pull request
Mar 24, 2021
…#13665) These changes (plus import changes) were necessary to make these tests pass on the `v2-main` branch. Back-porting to `master` to (hopefully) reduce future forward-merge pain. The 'returns base construct info if no more specific info is present' test was removed as is wasn't truly necessary, and does not work with V2, where Construct comes from the `constructs` library instead of `core.Construct`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…aws#13665) These changes (plus import changes) were necessary to make these tests pass on the `v2-main` branch. Back-porting to `master` to (hopefully) reduce future forward-merge pain. The 'returns base construct info if no more specific info is present' test was removed as is wasn't truly necessary, and does not work with V2, where Construct comes from the `constructs` library instead of `core.Construct`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes (plus import changes) were necessary to make these tests pass on
the
v2-mainbranch. Back-porting tomasterto (hopefully) reduce futureforward-merge pain.
The 'returns base construct info if no more specific info is present' test was
removed as is wasn't truly necessary, and does not work with V2, where Construct
comes from the
constructslibrary instead ofcore.Construct.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license