chore(deps): Upgrade major version of lerna #13723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
AFAIK, we don't use any of the features that are breaking in lerna-4.x
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
With the exception of dropping support for Node 6.x & 8.x, all other breaking changes were "internal" packages. |
eladb
pushed a commit
that referenced
this pull request
Mar 24, 2021
This resolves https://github.com/aws/aws-cdk/security/dependabot/yarn.lock/ssri/open Lerna is the root of the dependency chain causing this security alert. ```console => Found "ssri@6.0.1" info Reasons this module exists - "_project_#lerna#@lerna#publish#@evocateur#pacote" depends on it - Hoisted from "_project_#lerna#@lerna#publish#@evocateur#pacote#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@evocateur#npm-registry-fetch#make-fetch-happen#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@evocateur#pacote#cacache#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@lerna#pack-directory#@lerna#get-packed#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@lerna#npm-publish#@evocateur#libnpmpublish#ssri" ``` Unfortunately upgrading all transitive deps of the latest lerna version for `3.x` doesn't pull the necessary upgrade to resolve the alert. So it's either: 1. Wait for lerna to release a `3.x` patch to resolve this, which doesn't seem likely since the alert refers to a deep transitive dependency. 2. Manually and selectively upgrade the `ssri` package to a new major version - feels fragile. 3. Upgrade to lerna `4.x`. Opted for option 3 since it sounds the most reasonable. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
This resolves https://github.com/aws/aws-cdk/security/dependabot/yarn.lock/ssri/open Lerna is the root of the dependency chain causing this security alert. ```console => Found "ssri@6.0.1" info Reasons this module exists - "_project_#lerna#@lerna#publish#@evocateur#pacote" depends on it - Hoisted from "_project_#lerna#@lerna#publish#@evocateur#pacote#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@evocateur#npm-registry-fetch#make-fetch-happen#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@evocateur#pacote#cacache#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@lerna#pack-directory#@lerna#get-packed#ssri" - Hoisted from "_project_#lerna#@lerna#publish#@lerna#npm-publish#@evocateur#libnpmpublish#ssri" ``` Unfortunately upgrading all transitive deps of the latest lerna version for `3.x` doesn't pull the necessary upgrade to resolve the alert. So it's either: 1. Wait for lerna to release a `3.x` patch to resolve this, which doesn't seem likely since the alert refers to a deep transitive dependency. 2. Manually and selectively upgrade the `ssri` package to a new major version - feels fragile. 3. Upgrade to lerna `4.x`. Opted for option 3 since it sounds the most reasonable. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves https://github.com/aws/aws-cdk/security/dependabot/yarn.lock/ssri/open
Lerna is the root of the dependency chain causing this security alert.
Unfortunately upgrading all transitive deps of the latest lerna version for
3.xdoesn't pull the necessary upgrade to resolve the alert.So it's either:
3.xpatch to resolve this, which doesn't seem likely since the alert refers to a deep transitive dependency.ssripackage to a new major version - feels fragile.4.x.Opted for option 3 since it sounds the most reasonable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license