Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix up v2 from inaccurate merge commits #13751

Closed
wants to merge 24 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
94c1750
chore: forward merge 'master' into 'v2-main' (#13414)
aws-cdk-automation Mar 5, 2021
90f5311
fix(python): change Python namespace to `aws_cdk` (#13489)
rix0rrr Mar 9, 2021
361121b
Merge remote-tracking branch 'origin/v2-main' into v2/forward-merge-2…
RomainMuller Mar 9, 2021
095f852
Merge branch 'v2-main' into v2/forward-merge-20210309
RomainMuller Mar 9, 2021
4fa813e
chore: forward merge 'master' into 'v2-main'
RomainMuller Mar 9, 2021
340f3a2
Merge branch 'v2-main' into v2/forward-merge-20210310
mergify[bot] Mar 10, 2021
73f4d57
chore: forward merge 'master' into 'v2-main' (#13517)
mergify[bot] Mar 10, 2021
63a8cf1
chore(release): 2.0.0-alpha.7 (#13518)
aws-cdk-automation Mar 10, 2021
81b62c3
chore(release): 2.0.0-alpha.8 (#13632)
aws-cdk-automation Mar 17, 2021
516d892
Merge remote-tracking branch 'origin/v2-main' into v2/forward-merge-2…
iliapolo Mar 17, 2021
015ba49
automatic pkglint fixes
iliapolo Mar 17, 2021
52cd1b3
chore(core): fix runtime-info tests and imports for v2
njlynch Mar 18, 2021
b866d09
another import fix
njlynch Mar 18, 2021
2b8bc0b
chore: forward merge 'master' into 'v2-main' (#13631)
mergify[bot] Mar 18, 2021
4729cc1
Merge branch 'v2-main' into v2/forward-merge-20210318
iliapolo Mar 18, 2021
da49459
chore: forward merge 'master' into 'v2-main' (#13662)
mergify[bot] Mar 18, 2021
8176d99
Merge branch 'v2-main' into v2/forward-merge-20210319
Mar 19, 2021
ba97512
removing duplicate Construct import
njlynch Mar 19, 2021
23f1234
chore: forward merge 'master' into 'v2-main' (#13685)
Mar 19, 2021
1347ef6
Merge branch 'v2-main' into v2/forward-merge-20210320
iliapolo Mar 20, 2021
afe3219
chore: forward merge 'master' into 'v2-main'
iliapolo Mar 21, 2021
6275834
Merge branch 'v2-main' into v2/forward-merge-20210322
mergify[bot] Mar 22, 2021
a0b1c3c
chore: forward merge 'master' into 'v2-main' (#13730)
mergify[bot] Mar 22, 2021
0def2cf
chore: fix up v2 from inaccurate merge commits
njlynch Mar 23, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
423 changes: 423 additions & 0 deletions CHANGELOG.v2.md

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"include": "dependencies/node-version"
},
"scripts": {
"pkglint": "lerna --scope pkglint run build && lerna run pkglint",
"pkglint": "lerna run build --scope pkglint --include-dependencies && lerna run pkglint",
"build": "./build.sh",
"pack": "./pack.sh",
"compat": "./scripts/check-api-compatibility.sh",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import * as ec2 from '@aws-cdk/aws-ec2';
import * as ecs from '@aws-cdk/aws-ecs';
import * as cdk from '@aws-cdk/core';
import { Construct } from 'constructs';
import { EnvironmentCapacityType } from './extensions/extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

/**
* Settings for the environment you want to deploy.
* services within.
Expand Down Expand Up @@ -96,7 +92,7 @@ export class Environment extends Construct implements IEnvironment {
*/
public readonly capacityType: EnvironmentCapacityType;

private readonly scope: cdk.Construct;
private readonly scope: Construct;

constructor(scope: Construct, id: string, props?: EnvironmentProps) {
super(scope, id);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,11 @@ import * as ecs from '@aws-cdk/aws-ecs';
import * as iam from '@aws-cdk/aws-iam';
import * as cdk from '@aws-cdk/core';
import * as regionInfo from '@aws-cdk/region-info';
import { Construct } from 'constructs';
import { Service } from '../service';
import { Container } from './container';
import { ServiceExtension, ServiceBuild } from './extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

// The version of the App Mesh envoy sidecar to add to the task.
const APP_MESH_ENVOY_SIDECAR_VERSION = 'v1.15.1.0-prod';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import * as ec2 from '@aws-cdk/aws-ec2';
import * as ecs from '@aws-cdk/aws-ecs';
import * as route53 from '@aws-cdk/aws-route53';
import { Construct } from 'constructs';
import { Service } from '../../service';
import { Container } from '../container';
import { ServiceExtension, ServiceBuild, EnvironmentCapacityType } from '../extension-interfaces';
import { TaskRecordManager } from './task-record-manager';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

export interface AssignPublicIpExtensionOptions {
/**
* Enable publishing task public IPs to a recordset in a Route 53 hosted zone.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,7 @@ import * as route53 from '@aws-cdk/aws-route53';
import * as sqs from '@aws-cdk/aws-sqs';
import * as cdk from '@aws-cdk/core';
import * as customresources from '@aws-cdk/custom-resources';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';
import { Construct } from 'constructs';

export interface TaskRecordManagerProps {
service: ecs.Ec2Service | ecs.FargateService;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import * as ecs from '@aws-cdk/aws-ecs';
import * as iam from '@aws-cdk/aws-iam';
import { Construct } from 'constructs';
import { Service } from '../service';
import { ServiceExtension } from './extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

const CLOUDWATCH_AGENT_IMAGE = 'amazon/cloudwatch-agent:latest';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import * as ecs from '@aws-cdk/aws-ecs';
import { Construct } from 'constructs';
import { Service } from '../service';
import { ServiceExtension } from './extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

/**
* Setting for the main application container of a service
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import * as ecs from '@aws-cdk/aws-ecs';
import * as cdk from '@aws-cdk/core';
import { Construct } from 'constructs';
import { Service } from '../service';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

/**
* A list of the capacity types that are supported. These
* capacity types may change the behavior of an extension.
Expand Down Expand Up @@ -109,7 +106,7 @@ export abstract class ServiceExtension {
* the extension is told what Service it is now working on.
*/
protected parentService!: Service;
protected scope!: cdk.Construct;
protected scope!: Construct;

// A list of other extensions which want to mutate the
// container definition for this extension.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
import * as ecs from '@aws-cdk/aws-ecs';
import * as awslogs from '@aws-cdk/aws-logs';
import * as cdk from '@aws-cdk/core';
import { Construct } from 'constructs';
import { Service } from '../service';
import { Container } from './container';
import { ContainerMutatingHook, ServiceExtension } from './extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

/**
* Settings for the hook which mutates the application container
* to route logs through FireLens
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import * as ecs from '@aws-cdk/aws-ecs';
import * as alb from '@aws-cdk/aws-elasticloadbalancingv2';
import * as cdk from '@aws-cdk/core';
import { Construct } from 'constructs';
import { Service } from '../service';
import { ServiceExtension, ServiceBuild } from './extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

/**
* This extension add a public facing load balancer for sending traffic
* to one or more replicas of the application container
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import * as ecs from '@aws-cdk/aws-ecs';
import * as iam from '@aws-cdk/aws-iam';
import * as cdk from '@aws-cdk/core';
import { Construct } from 'constructs';
import { Service } from '../service';
import { ServiceExtension } from './extension-interfaces';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

const XRAY_DAEMON_IMAGE = 'amazon/aws-xray-daemon:latest';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
import * as ec2 from '@aws-cdk/aws-ec2';
import * as ecs from '@aws-cdk/aws-ecs';
import * as cdk from '@aws-cdk/core';
import { Construct } from 'constructs';
import { IEnvironment } from './environment';
import { EnvironmentCapacityType, ServiceBuild } from './extensions/extension-interfaces';
import { ServiceDescription } from './service-description';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';

/**
* The settings for an ECS Service
*/
Expand Down Expand Up @@ -76,7 +72,7 @@ export class Service extends Construct {
*/
private urls: Record<string, string> = {};

private readonly scope: cdk.Construct;
private readonly scope: Construct;

constructor(scope: Construct, id: string, props: ServiceProps) {
super(scope, id);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@aws-cdk-containers/ecs-service-extensions",
"version": "0.0.0",
"private": true,
"description": "The CDK Construct Library that helps you build ECS services using simple extensions",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -66,7 +67,7 @@
"@aws-cdk/core": "0.0.0",
"@aws-cdk/custom-resources": "0.0.0",
"@aws-cdk/region-info": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"homepage": "https://github.com/aws/aws-cdk",
"peerDependencies": {
Expand All @@ -91,7 +92,7 @@
"@aws-cdk/core": "0.0.0",
"@aws-cdk/custom-resources": "0.0.0",
"@aws-cdk/region-info": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
Expand Down
5 changes: 3 additions & 2 deletions packages/@aws-cdk/alexa-ask/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@aws-cdk/alexa-ask",
"version": "0.0.0",
"private": true,
"description": "The CDK Construct Library for Alexa::ASK",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -79,11 +80,11 @@
},
"dependencies": {
"@aws-cdk/core": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"peerDependencies": {
"@aws-cdk/core": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,7 @@ import * as events from '@aws-cdk/aws-events';
import * as iam from '@aws-cdk/aws-iam';
import * as cxschema from '@aws-cdk/cloud-assembly-schema';
import * as cdk from '@aws-cdk/core';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';
import { Construct } from 'constructs';

export interface PipelineDeployStackActionProps {
/**
Expand Down
5 changes: 3 additions & 2 deletions packages/@aws-cdk/app-delivery/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"name": "@aws-cdk/app-delivery",
"description": "Continuous Integration / Continuous Delivery for CDK Applications",
"deprecated": "Use the @aws-cdk/pipelines module instead",
"private": true,
"version": "0.0.0",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -55,7 +56,7 @@
"@aws-cdk/core": "0.0.0",
"@aws-cdk/cx-api": "0.0.0",
"@aws-cdk/cloud-assembly-schema": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"devDependencies": {
"@aws-cdk/assert": "0.0.0",
Expand Down Expand Up @@ -93,7 +94,7 @@
"@aws-cdk/core": "0.0.0",
"@aws-cdk/cx-api": "0.0.0",
"@aws-cdk/cloud-assembly-schema": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/@aws-cdk/assert/lib/synth-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export class SynthUtils {
/**
* Returns the cloud assembly template artifact for a stack.
*/
public static synthesize(stack: core.Stack, options: core.SynthesisOptions = { }): cxapi.CloudFormationStackArtifact {
public static synthesize(stack: core.Stack, options: core.StageSynthesisOptions = { }): cxapi.CloudFormationStackArtifact {
// always synthesize against the root (be it an App or whatever) so all artifacts will be included
const assembly = synthesizeApp(stack, options);
return assembly.getStackArtifact(stack.artifactId);
Expand All @@ -16,7 +16,7 @@ export class SynthUtils {
/**
* Synthesizes the stack and returns the resulting CloudFormation template.
*/
public static toCloudFormation(stack: core.Stack, options: core.SynthesisOptions = { }): any {
public static toCloudFormation(stack: core.Stack, options: core.StageSynthesisOptions = { }): any {
const synth = this._synthesizeWithNested(stack, options);
if (synth instanceof cxapi.CloudFormationStackArtifact) {
return synth.template;
Expand Down Expand Up @@ -48,7 +48,7 @@ export class SynthUtils {
* @return CloudFormationStackArtifact for normal stacks or the actual template for nested stacks
* @internal
*/
public static _synthesizeWithNested(stack: core.Stack, options: core.SynthesisOptions = { }): cxapi.CloudFormationStackArtifact | object {
public static _synthesizeWithNested(stack: core.Stack, options: core.StageSynthesisOptions = { }): cxapi.CloudFormationStackArtifact | object {
// always synthesize against the root (be it an App or whatever) so all artifacts will be included
const assembly = synthesizeApp(stack, options);

Expand All @@ -64,7 +64,7 @@ export class SynthUtils {
/**
* Synthesizes the app in which a stack resides and returns the cloud assembly object.
*/
function synthesizeApp(stack: core.Stack, options: core.SynthesisOptions) {
function synthesizeApp(stack: core.Stack, options: core.StageSynthesisOptions) {
const root = stack.node.root;
if (!core.Stage.isStage(root)) {
throw new Error('unexpected: all stacks must be part of a Stage or an App');
Expand Down
5 changes: 3 additions & 2 deletions packages/@aws-cdk/assert/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@aws-cdk/assert",
"version": "0.0.0",
"private": true,
"description": "An assertion library for use with CDK Apps",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -32,11 +33,11 @@
"@aws-cdk/cloudformation-diff": "0.0.0",
"@aws-cdk/core": "0.0.0",
"@aws-cdk/cx-api": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"peerDependencies": {
"@aws-cdk/core": "0.0.0",
"constructs": "^3.2.0",
"constructs": "10.0.0-pre.5",
"jest": "^26.6.3"
},
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/assets/lib/staging.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { FingerprintOptions } from './fs/options';

// keep this import separate from other imports to reduce chance for merge conflicts with v2-main
// eslint-disable-next-line no-duplicate-imports, import/order
import { Construct } from '@aws-cdk/core';
import { Construct } from 'constructs';

/**
* Deprecated
Expand Down
5 changes: 3 additions & 2 deletions packages/@aws-cdk/assets/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@aws-cdk/assets",
"version": "0.0.0",
"private": true,
"description": "This module is deprecated. All types are now available under the core module",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -81,13 +82,13 @@
"dependencies": {
"@aws-cdk/core": "0.0.0",
"@aws-cdk/cx-api": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"homepage": "https://github.com/aws/aws-cdk",
"peerDependencies": {
"@aws-cdk/core": "0.0.0",
"@aws-cdk/cx-api": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
Expand Down
5 changes: 3 additions & 2 deletions packages/@aws-cdk/aws-accessanalyzer/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "@aws-cdk/aws-accessanalyzer",
"version": "0.0.0",
"private": true,
"description": "The CDK Construct Library for AWS::AccessAnalyzer",
"main": "lib/index.js",
"types": "lib/index.d.ts",
Expand Down Expand Up @@ -80,11 +81,11 @@
},
"dependencies": {
"@aws-cdk/core": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"peerDependencies": {
"@aws-cdk/core": "0.0.0",
"constructs": "^3.2.0"
"constructs": "10.0.0-pre.5"
},
"engines": {
"node": ">= 10.13.0 <13 || >=13.7.0"
Expand Down
Loading