Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SetPeriodToTimeRange to GraphWidget #13776

Closed

Conversation

mmamedel
Copy link

The SetPeriodToTimeRange is a property that is already available in the SingleValueWidget Construct but is missing from the GraphWidget Construct. With CfnDashboard, one can add the property like:

const CloudWatchDashboard = new cloudwatch.CfnDashboard(this, 'CloudWatchDashboard', {
  dashboardName: "dashboardName",
  dashboardBody: JSON.stringify({
    widgets: [{
      type: "metric",
      properties: {
        view: "pie",
	/** other properties */
        setPeriodToTimeRange: true // <- Here
      }
    }]
  })
})

@gitpod-io
Copy link

gitpod-io bot commented Mar 24, 2021

@mergify
Copy link
Contributor

mergify bot commented Mar 24, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@mmamedel mmamedel changed the title Add SetPeriodToTimeRange to GraphWidget feat: Add SetPeriodToTimeRange to GraphWidget Mar 24, 2021
@NetaNir NetaNir assigned NetaNir and unassigned rix0rrr May 19, 2021
packages/@aws-cdk/aws-cloudwatch/README.md Outdated Show resolved Hide resolved
@NetaNir NetaNir added the pr-linter/exempt-readme The PR linter will not require README changes label May 19, 2021
@NetaNir NetaNir removed their assignment Jun 22, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jun 24, 2021

@mergify mergify bot dismissed NetaNir’s stale review June 24, 2021 22:48

Pull request has been modified.

@NetaNir
Copy link
Contributor

NetaNir commented Jun 24, 2021

added in #14659

@NetaNir NetaNir closed this Jun 24, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ba596fa
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants