chore(aws-cdk-lib): strip out deprecated symbols from public API #13815
Conversation
|
|
|
Needs to run after #13814 for the build to succeed. |
| if (!Object.values(cxschema.ContextProvider).includes(report.provider as cxschema.ContextProvider)) { | ||
| throw new Error(`Unknown context provider requested in: ${JSON.stringify(report)}`); | ||
| } |
There was a problem hiding this comment.
As-is, these checks will be removed in v2. Is that intentional?
There was a problem hiding this comment.
I believe this is only needed because cxapi.MissingContext needs to be converted into cxschema.MissingContext.
Specifically, the provider prop is a string in the former and an enum in the latter.
Hence not required in the new API.
cc @rix0rrr to confirm who introduced the change.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -33,7 +33,8 @@ | |||
| "cdk-build": { | |||
| "eslint": { | |||
| "disable": true | |||
| } | |||
| }, | |||
| "stripDeprecated": true | |||
There was a problem hiding this comment.
curious why this is not in the jsii config. @RomainMuller?
…#13815) The jsii build the 'aws-cdk-lib' module will now run with the 'strip deprecated' flag enabled. This ensures that the public API of this module will contain no deprecated symbols. This is enabled by a new option configured in the module's `package.json` and recognized by `cdk-build`. Previous commits - ca391b5 and a872e67 - have removed the majority of deprecated symbols from public APIs. A few remain that are removed as part of this change. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#13815) The jsii build the 'aws-cdk-lib' module will now run with the 'strip deprecated' flag enabled. This ensures that the public API of this module will contain no deprecated symbols. This is enabled by a new option configured in the module's `package.json` and recognized by `cdk-build`. Previous commits - ca391b5 and a872e67 - have removed the majority of deprecated symbols from public APIs. A few remain that are removed as part of this change. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The jsii build the 'aws-cdk-lib' module will now run with the 'strip
deprecated' flag enabled. This ensures that the public API of this
module will contain no deprecated symbols.
This is enabled by a new option configured in the module's
package.jsonand recognized bycdk-build.Previous commits - ca391b5 and a872e67 - have removed the majority of
deprecated symbols from public APIs. A few remain that are removed as
part of this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license