Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 1.95.2 #13885

Merged
merged 5 commits into from
Mar 30, 2021
Merged

chore(release): 1.95.2 #13885

merged 5 commits into from
Mar 30, 2021

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Mar 30, 2021

see CHANGELOG


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Niranjan Jayakar and others added 3 commits March 30, 2021 15:17
netmask@1 is affected by CVE-2021-28918
GHSA-pch5-whg9-qr2r

netmask is a depdendency to the CDK via

  aws-cdk → proxy-agent@4.0.1 → pac-proxy-agent@4.1.0 →
  pac-resolver@4.1.0 → netmask@1.0.6

None of these dependencies have upgraded to netmask@2 as yet.

Use yarn's [selective dependency resolution], to explicitly pick
netmask@2. This upgrades yarn.lock and the CLI's npm-shrinkwrap.json.
With this fix, npm customers will no longer depend on netmask@2
transitively via the CDK.

For yarn customers, there is no clean resolution since yarn does not
respective the the 'resolutions' key in dependencies' package.json and
does not respect the shrinkwrap.
The init templates now ship the 'resolutions' key so that new customers
using yarn will be unaffected.

A different solution has to be devised for existing customers on yarn.

[selective dependency resolution]: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@gitpod-io
Copy link

gitpod-io bot commented Mar 30, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c9dbc12
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ae4bfd1 into master Mar 30, 2021
@mergify mergify bot deleted the patch/v1.95.2 branch March 30, 2021 23:36
NetaNir added a commit that referenced this pull request Mar 30, 2021
@NetaNir NetaNir restored the patch/v1.95.2 branch March 30, 2021 23:58
@NetaNir NetaNir deleted the patch/v1.95.2 branch March 31, 2021 00:07
mergify bot pushed a commit that referenced this pull request Mar 31, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 31, 2021
see [CHANGELOG](https://github.com/aws/aws-cdk/blob/ebb5c7af622ab36f46e58103608dfc025a21691a/CHANGELOG.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 31, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
see [CHANGELOG](https://github.com/aws/aws-cdk/blob/ebb5c7af622ab36f46e58103608dfc025a21691a/CHANGELOG.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants