Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): Cache Policy headers enforce soft limit of 10 #13904

Merged
merged 3 commits into from
Apr 2, 2021

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Mar 31, 2021

Validation was added in #13425 to enforce a limit of the number of headers
allowed in the allow list for a Cache Policy; that limit is a soft limit and
should not be hard-enforced in code.

fixes #13903

This reverts commit e08213f.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Validation was added in #13425 to enforce a limit of the number of headers
allowed in the allow list for a Cache Policy; that limit is a soft limit and
should not be hard-enforced in code.

fixes #13903

This reverts commit e08213f.
@njlynch njlynch requested a review from a team March 31, 2021 13:39
@njlynch njlynch self-assigned this Mar 31, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 31, 2021

@github-actions github-actions bot added the @aws-cdk/aws-cloudfront Related to Amazon CloudFront label Mar 31, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 31, 2021
@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Apr 2, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8a66244 into master Apr 2, 2021
@mergify mergify bot deleted the njlynch/revert-headers-limit branch April 2, 2021 14:01
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ea2bfbc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…3904)

Validation was added in aws#13425 to enforce a limit of the number of headers
allowed in the allow list for a Cache Policy; that limit is a soft limit and
should not be hard-enforced in code.

fixes aws#13903

This reverts commit e08213f.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloudfront: Maximum number of allowlisted headers in Cache Policy is incorrectly set to 10
3 participants