docs(lambda): Use bundlingImage rather than bundlingDockerImage

[michaelbrewer]

Resolves #13944

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[jogold]

Runtimes still expose a bundlingDockerImage property, no?

aws-cdk/packages/@aws-cdk/aws-lambda/lib/runtime.ts

Line 14 in 767cd31

readonly bundlingDockerImage?: string;

[michaelbrewer]

bundlingDockerImage

This actually does not work either.

[michaelbrewer]

@jogold if i use bundlingDockerImage i get a casting error in Java. and if bundlingImage it does not actually deploy the code.

[michaelbrewer]

Runtimes still expose a bundlingDockerImage property, no?

aws-cdk/packages/@aws-cdk/aws-lambda/lib/runtime.ts

Line 14 in 767cd31

readonly bundlingDockerImage?: string;

Yes, it does but with typed languages you now have to force a cast:

ie: (Runtime.PYTHON_3_8.bundlingDockerImage as DockerImage?

And the deprecation warning suggests you should use bundlingImage, which does not actually work.

Below is a working example using the now deprecated bundlingDockerImage

        val function = Function(
            this,
            "loan${type.capitalize()}Function",
            FunctionProps
                .builder()
                .functionName("loanDevl")
                .handler("loan.app.lambda_handler")
                .runtime(Runtime.PYTHON_3_8)
                .code(
                    Code.fromAsset(
                        "../../src/",
                        AssetOptions
                            .builder()
                            .bundling(
                                BundlingOptions
                                    .builder()
                                    .image(Runtime.PYTHON_3_8.bundlingDockerImage as DockerImage?)
                                    .command(
                                        mutableListOf(
                                            "bash",
                                            "-c",
                                            "pip install -r requirements.txt -t /asset-output && cp -au . /asset-output"
                                        )
                                    )
                                    .build()
                            )
                            .build()
                    )
                )
                .build()
        )

[michaelbrewer]

Seems like these changes are current, I just an issue when running my unit tests and then run the a cdk deploy

[jogold]

And the deprecation warning suggests you should use bundlingImage

you're right!

[michaelbrewer]

And the deprecation warning suggests you should use bundlingImage

you're right!

And this would also trigger a compilation error on Java / Kotlin (and i am sure other languages).

What was confusing for me was when i switched bundlingImage switch, it did not properly deployed. It turned out that you need to delete the cdk.out folder if a build fails, otherwise it just uploads the directory specified, but without the dependencies. I am sure there is another issue for that to?

[michaelbrewer]

Note @nija-at this causes compile errors in Java runtime

[michaelbrewer]

@nija-at will this be merged? It was a time sink for me when I came across this documentation error.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[michaelbrewer]

@nija-at mergify is just hanging now?

Pull request has been modified.

[michaelbrewer]

@nija-at @mergify is not working for me. And this is a PR from my personal github account

[mergify]

@michaelbrewer is not allowed to run commands

Hey, I reacted but my real name is @Mergifyio

[nija-at]

@michaelbrewer - we're having trouble with Mergify across the repo since yesterday. We will get this merged eventually.

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: 817bc9f
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).