fix(elasticsearch): update extractNameFromEndpoint method to remove #14052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earch- prefix from domainEndpoint fixes: aws#13380
|
|
github-actions
bot
added
the
@aws-cdk/aws-elasticsearch
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@saudkhanzada Is this ready for review or should remain in draft? |
iliapolo
added
the
response-requested
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
the
closing-soon
|
Spotted this issue today when trying to give permissions through The permission resource is constructed using the extracted domain name, which is wrong. |
github-actions
bot
removed
closing-soon
|
@saudkhanzada What is the status of this PR? |
iliapolo
added
the
response-requested
|
Closing because the bot missed the response-requested label. Please ping me if you'd like to reopen this |
|
@iliapolo, Sorry for the late response, I will complete it on this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search- prefix from domainEndpoint
fixes: #13380
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license