fix(aws-cloudfront): distribution comment length not validated (#14020)

[minuz]

fixes #14020

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[minuz]

@njlynch not sure if this is normal, but I had to use lint --fix, probably due to my local vscode settings and the PR end up getting a bit polluted with those fixes.

[njlynch]

not sure if this is normal, but I had to use lint --fix, probably due to my local vscode settings and the PR end up getting a bit polluted with those fixes.

Yeah, looks like your local VSCode settings are quite different from ours! Unfortunately, this makes the diff almost impossible to read. Can you clean this up? One approach might be to use git reset + git add -p to reset (not remove) all of these changes, and then only add back in the relevant lines. As-is, there are too many unrelated changes here for me to be confident reviewing just the few lines of comments-related stuff.

Pull request has been modified.

[minuz]

not sure if this is normal, but I had to use lint --fix, probably due to my local vscode settings and the PR end up getting a bit polluted with those fixes.

Yeah, looks like your local VSCode settings are quite different from ours! Unfortunately, this makes the diff almost impossible to read. Can you clean this up? One approach might be to use git reset + git add -p to reset (not remove) all of these changes, and then only add back in the relevant lines. As-is, there are too many unrelated changes here for me to be confident reviewing just the few lines of comments-related stuff.

No worries, I've cleaned up the PR and now it's only the actual changes.

[njlynch]

Thanks! 👍

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: e1dbf0e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).