fix(core): toJsonString() does not deal correctly with list tokens
#14138
Conversation
For reasons explained in the previous PR, list tokens need to be run through a custom resource. This custom resource gets added during token resolution, but because that is run multiple times the side effect of adding the custom resource gets executed multiple times. Add a cache to make sure the second execution returns the first answer as the first one. Not a fantastic solution, but given the constraints of Lazies, I'm not sure we can do any better. Fixes #14088.
|
|
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio refresh |
|
Command
|
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@rix0rrr Would you be open to do a bugfix release for this? The missing cache breaks some of my custom resources in production that now reference CdkJsonStringify resources that do not exist at all. |
…ws#14138) For reasons explained in the previous PR, list tokens need to be run through a custom resource. This custom resource gets added during token resolution, but because that is run multiple times the side effect of adding the custom resource gets executed multiple times. Add a cache to make sure the second execution returns the first answer as the first one. Not a fantastic solution, but given the constraints of Lazies, I'm not sure we can do any better. Fixes aws#14088. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
For reasons explained in the previous PR, list tokens need to be run
through a custom resource. This custom resource gets added during token
resolution, but because that is run multiple times the side effect
of adding the custom resource gets executed multiple times.
Add a cache to make sure the second execution returns the first answer
as the first one.
Not a fantastic solution, but given the constraints of Lazies, I'm not
sure we can do any better.
Fixes #14088.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license