fix(cli): wrong account used when containers are pushed, a followup from #7022 #14151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
requested changes
Apr 21, 2021
There was a problem hiding this comment.
I believe you, but I have a hard time understanding the PR message and the code confuses me.
It's turning a VALUE into a FUNCTION? And this is correct?
Can you please explain the PR body what the issue is, what the root cause is and why the code change fixes it?
And this probably needs a test as well...
|
Ah I see, we're purposely turning a value into a thunk. That's fine I suppose, but we need the thunk evaluated properly in the places where we used to use the value. That code you linked had more changes than just this one, as you'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation on fix from #7022, the container push was missed.
Duplicates account lookup used on files, for containers: afd7045#diff-ae0c51f3723b61d922c2c1db93891e22ab0b78b95a24b9794044d4c140bfd649L28-R30
Resolves #14008
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license