feat(apigatewayv2): introduce new interface for integration with sfn tasks and r53 targets #14202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tasks and r53 targets
|
|
github-actions
bot
added
the
@aws-cdk/aws-apigatewayv2
nija-at
suggested changes
Apr 16, 2021
packages/@aws-cdk/aws-route53-targets/lib/api-gatewayv2-domain-name.ts
Outdated
Show resolved
Hide resolved
Comment on lines
-16
to
+25
| readonly api: apigatewayv2.IHttpApi; | ||
| readonly api: IApiGatewayV2HttpApi; |
There was a problem hiding this comment.
Why not just make this -
readonly apiId: stringThere was a problem hiding this comment.
- Because of the way it is used in the consumer. The consumer code requires the apigw containing Construct in order to get the defining Stack to get its region:
const apiStack = cdk.Stack.of(this.props.api);
return `${this.props.api.apiId}.execute-api.${apiStack.region}.${apiStack.urlSuffix}`;
The way to express it with an interface is to have it extends IConstruct which will enforce the requirements of a scope.
Since we decided to merge this change to master (in the chat), keeping the interface has the advantage of not breaking typescript users.
…-name.ts Co-authored-by: Niranjan Jayakar <nija@amazon.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
closed in favor of #14227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stepfunctions-tasksandroute53-targetsare stable modules, meaning that in v2 they can not have a dependency on experimental modules (to avoid cyclic dependencies). Currently both depends onapigatewayv2. This PR breaks the two dependencies by introducing the appropriate interface in each module.Note that since these are breaking changes to stable modules, they can not be merged to master.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license